Skip to content

Conversation

@LLee233
Copy link
Contributor

@LLee233 LLee233 commented Feb 29, 2024

PR types

Others

PR changes

OPs

Description

Based on requirement, we add new op conv2d_transpose_bias (conv2d_transpose with input bias) for oneDNN backend, avoiding catching bias from "dev_ctx".

@paddle-bot
Copy link

paddle-bot bot commented Feb 29, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Feb 29, 2024
@LLee233
Copy link
Contributor Author

LLee233 commented Mar 4, 2024

Hi @yuanlehome , would you mind taking a look at the CI result? For static check of CI, I here only follow what data type conv2d_transpose supports, which I suppose it's okay? Thanks~

@LLee233
Copy link
Contributor Author

LLee233 commented Mar 4, 2024

Hi @vivienfanghuagood, would you mind having a review on this code and see if it's what you want for conv_transpose_bias op? Thanks~
CC @xinyu-intel @zhanglirong1999

@LLee233 LLee233 force-pushed the conv2d_transpose_bias branch from 79963e1 to abb757d Compare March 4, 2024 06:39
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LLee233
Copy link
Contributor Author

LLee233 commented Mar 5, 2024

Hi @yuanlehome , would you mind taking a look at the CI result? For static check of CI, I here only follow what data type conv2d_transpose supports, which I suppose it's okay? Thanks~

Hello it's me again @yuanlehome. Could you help me with the static check of CI? The reason is as said above. Thanks~

@yuanlehome yuanlehome requested a review from Aurelius84 March 5, 2024 06:04
@xinyu-intel xinyu-intel merged commit 2c4629c into PaddlePaddle:develop Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers Intel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants