Skip to content

Conversation

@Fridge003
Copy link

@Fridge003 Fridge003 commented Feb 29, 2024

PR types

Others

PR changes

Others

Description

Delete class TracedLayer from paddle/jit/api.py, as well as several helper methods that only this class calls.

The deleted helper methods include _trace, extract_vars, _extract_vars, create_program_from_desc, and they are all located in paddle/jit/api.py.

Unit tests related to this class are also deleted.

PCard-66972

@CLAassistant
Copy link

CLAassistant commented Feb 29, 2024

CLA assistant check
All committers have signed the CLA.

@paddle-bot
Copy link

paddle-bot bot commented Feb 29, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

目测没啥问题,等 CI 过完应该就可以了~

@SigureMo SigureMo self-assigned this Feb 29, 2024
@SigureMo SigureMo changed the title Delete legacy class TracedLayer and its related unit tests [Dy2St] Delete legacy class TracedLayer and its related unit tests Feb 29, 2024
@SigureMo SigureMo merged commit 102c515 into PaddlePaddle:develop Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants