Skip to content

Conversation

@diadestiny
Copy link
Contributor

@diadestiny diadestiny commented Feb 22, 2024

PR types

Others

PR changes

Others

Description

python 3.12 支持 RETURN_CONST

@paddle-bot
Copy link

paddle-bot bot commented Feb 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Feb 22, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以及有几个硬编码为 "RETURN_VALUE" 的情况可能需要适配一下,提取常量 RETURNopcode_info.py,并在使用处调用,可以下一个 PR 尝试做一下~

self._graph.start_compile(ret_const)
self._graph.pycode_gen.gen_return()
self.new_code = self._graph.pycode_gen.gen_pycode()
return Stop(state="Return")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里可以考虑服用下 RETURN_VALUE 的代码,抽出来一个公共函数~

@SigureMo
Copy link
Member

冲突了 😂

gouzil
gouzil previously approved these changes Feb 22, 2024
@gouzil
Copy link
Member

gouzil commented Feb 22, 2024

TODO:test_sot_exporttest_str_format也可以打开了

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 8ee6609 into PaddlePaddle:develop Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants