[Cleanup][B-4] clean some paddle.base.dygraph.to_variable for test #61793
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
|
需要按照模板重新填写下 PR 描述，另外 PR 描述里应该包含 tracking issue，PR 标题应该符合 tracking issue 里的模式，都需要调整下，可参考其它 PR
当前不需要处理 |
SigureMo
left a comment
SigureMo
left a comment
There was a problem hiding this comment.
以及
- 标题没改
- 没链 tracking issue
- 描述改的不对，仍然不符合模板，在没有确定内容之前不要随便删模板内容，模板内容在这里 https://github.com/PaddlePaddle/Paddle/blob/develop/.github/PULL_REQUEST_TEMPLATE.md?plain=1
| with dg.guard(): | ||
| x = dg.to_variable(a, "x") | ||
| y = dg.to_variable(b) | ||
| x = paddle.to_tensor(a, "x") |
There was a problem hiding this comment.
两者签名分别如下
def to_variable(value, name=None, zero_copy=None, dtype=None): ...
def to_tensor(data, dtype=None, place=None, stop_gradient=True): ...这里将原来的 name 传递到 dtype 了，name 参数在这里无用，删掉吧
| x = paddle.to_tensor(a, "x") | ||
| y = paddle.to_tensor(b) | ||
| out = paddle.add(x, y) | ||
| self.assertIsNotNone(f"{out}") |
There was a problem hiding this comment.
这个 assert 删掉吧，没啥用，f"{out}" 永远不可能为 None
| var_x = dg.to_variable(x) | ||
| var_y = dg.to_variable(y) | ||
| var_x = paddle.to_tensor(x) | ||
| var_y = paddle.to_tensor(x) |
There was a problem hiding this comment.
| var_y = paddle.to_tensor(x) | |
| var_y = paddle.to_tensor(y) |
flying-forever
changed the title
flying-forever
changed the title
paddle.base.dygraph.to_variable for test
flying-forever
changed the title
paddle.base.dygraph.to_variable for test
3 participants
PR types
Others
PR changes
Others
Description
B4
@gouzil