Skip to content

[PIR] pir onednn cast #61649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghuancoder merged 3 commits into from
Feb 7, 2024
Merged

[PIR] pir onednn cast #61649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e86d0aa
pir onednn support cast
wanghuancoder Feb 6, 2024
1150c49
refine
wanghuancoder Feb 6, 2024
758d3e7
refine
wanghuancoder Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion paddle/fluid/pir/dialect/operator/ir/ops_onednn_extra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

# - op : bilinear_interp

# - op : cast
- op : cast
dynamic_fallback : True

- op : clip
extra_args : str mkldnn_data_type="float32"
Expand Down
14 changes: 13 additions & 1 deletion paddle/phi/kernels/onednn/cast_kernel.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,16 @@

namespace phi {

bool CastCheckIfOneDNNSupport(const KernelContext* ctx) {
if ((ctx->InputAt<phi::DenseTensor>(0).dtype() != DataType::FLOAT32 &&
ctx->InputAt<phi::DenseTensor>(0).dtype() != DataType::BFLOAT16) ||
(ctx->AttrAt<DataType>(0) != DataType::FLOAT32 &&
ctx->AttrAt<DataType>(0) != DataType::BFLOAT16)) {
return false;
}
return true;
}

template <typename T, typename Context>
void CastKernel(const Context& dev_ctx,
const DenseTensor& x,
Expand Down Expand Up @@ -56,4 +66,6 @@ void CastKernel(const Context& dev_ctx,
} // namespace phi

PD_REGISTER_KERNEL(
cast, OneDNN, ONEDNN, phi::CastKernel, float, phi::dtype::bfloat16) {}
cast, OneDNN, ONEDNN, phi::CastKernel, float, phi::dtype::bfloat16) {
kernel->check_if_onednn_kernel_support_ = phi::CastCheckIfOneDNNSupport;
}
3 changes: 2 additions & 1 deletion test/mkldnn/test_cast_mkldnn_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def setUp(self):
self.op_type = 'cast'

def test_check_output(self):
self.check_output(check_dygraph=False)
self.check_output(check_dygraph=False, check_pir_onednn=True)

def test_check_grad(self):
self.check_grad_with_place(
Expand All @@ -57,6 +57,7 @@ def test_check_grad(self):
check_dygraph=False,
user_defined_grads=[self.inputs['X']],
user_defined_grad_outputs=[self.outputs['Out']],
check_pir_onednn=True,
)

def init_shape(self):
Expand Down