[CINN] Deleta cache in split_generate_shape_into_shape_ops_pass #61611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
jiahy0825
approved these changes
Feb 6, 2024
Comment on lines
-380
to
+366
| return op->isa<pir::ModuleOp>() && op->num_regions() > 0; | ||
| return op->num_regions() > 0; |
Contributor
Author
There was a problem hiding this comment.
这个pass也要进到if的子block中处理，需要去掉ModuleOp的判断才能进去
tc20042008
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-73448
修复generate_shape拆分为普通shape类算子时使用cache导致Value跨block引用的问题。本PR中移除了cache的使用，可能会有一定的性能损失，但预计影响不大，后续出现性能问题时再进行专项优化。