Skip to content

Conversation

@wanghuancoder
Copy link
Contributor

@wanghuancoder wanghuancoder commented Feb 2, 2024

PR types

New features

PR changes

Others

Description

Pcard-74613

#61474
遗留了6个单测没有测试成功。经分析如下:

  1. 修复单测:
  • test_reduce_mkldnn_op.py中,reduce_sum OP不该标记mkldnn_data_type
  • test_reduce_mkldnn_op.py中,reduce_mean存在更多类型的attrs,需要Instruction适配
  • test_reduce_mkldnn_op.py中,PHI中已经不再支持reduce_all的显示传入。因此reduce_all相关的三个单测跳过
  • test_nearest_interp_mkldnn_op.py不需要适配OneDNN,只需要适配V2版本
  1. 回滚yaml
  • test_bilinear_interp_v2_mkldnn_op.py 单测依赖前置工作:如果CPU Kernel不支持BF16,则使用OneDNN Kernel。后续提交。
  • test_multi_gru_mkldnn_op.py,multi_gru还没有签到PHI,也没有yaml。后续提交。
  • test_shape_mkldnn_op.py,shape,暴露了目前PIR-OneDNN没有适配yaml中的skip_transform机制。后续需要支持。

TODO:reduce相关的算子虽然已经适配yaml,但还需要支持动态fallback到CPU逻辑。

@wanghuancoder wanghuancoder changed the title Pir onednn ops yaml2 [PIR] onednn ops yaml2 Feb 2, 2024
@phlrain phlrain self-requested a review February 6, 2024 02:16
@wanghuancoder wanghuancoder merged commit efb06f4 into PaddlePaddle:develop Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants