Skip to content

Conversation

@ooooo-create
Copy link
Contributor

PR types

Others

PR changes

Others

Description

link #61385
替换 dtype == VarType.FP32 的 case 为 dtype == paddle.float32
@SigureMo @gouzil

@SigureMo
Copy link
Member

SigureMo commented Feb 2, 2024

2024-02-02 13:58:24 ======================================================================
2024-02-02 13:58:24 FAIL: test_static_add (test_elementwise_add_op.TestBoolAddFloatElementwiseAddop)
2024-02-02 13:58:24 ----------------------------------------------------------------------
2024-02-02 13:58:24 Traceback (most recent call last):
2024-02-02 13:58:24   File "C:\home\workspace\Paddle\build\test\legacy_test\test_elementwise_add_op.py", line 784, in test_static_add
2024-02-02 13:58:24     self.assertTrue(c.dtype == paddle.float32)
2024-02-02 13:58:24 AssertionError: False is not true
2024-02-02 13:58:24 ----------------------------------------------------------------------

test_elementwise_add_op 看样子挂了,可以这个 PR 先 revert 该文件的修改,下个 PR 调试看看是什么问题

@ooooo-create
Copy link
Contributor Author

2024-02-02 13:58:24 ======================================================================
2024-02-02 13:58:24 FAIL: test_static_add (test_elementwise_add_op.TestBoolAddFloatElementwiseAddop)
2024-02-02 13:58:24 ----------------------------------------------------------------------
2024-02-02 13:58:24 Traceback (most recent call last):
2024-02-02 13:58:24   File "C:\home\workspace\Paddle\build\test\legacy_test\test_elementwise_add_op.py", line 784, in test_static_add
2024-02-02 13:58:24     self.assertTrue(c.dtype == paddle.float32)
2024-02-02 13:58:24 AssertionError: False is not true
2024-02-02 13:58:24 ----------------------------------------------------------------------

test_elementwise_add_op 看样子挂了,可以这个 PR 先 revert 该文件的修改,下个 PR 调试看看是什么问题

哦哦,是我改错了(
image

@SigureMo
Copy link
Member

SigureMo commented Feb 2, 2024

DataType 不可以改的,现在 DataType 还没绑到 paddle.float32,这个任务的最终目标就是 DataType 绑到 paddle.float32

@ooooo-create
Copy link
Contributor Author

DataType 不可以改的,现在 DataType 还没绑到 paddle.float32,这个任务的最终目标就是 DataType 绑到 paddle.float32

除了 dtype == VarType.FP32 这样的,别的地方使用 VarType 需要修改嘛
好像还有 assertEqual 这种
image

@SigureMo
Copy link
Member

SigureMo commented Feb 2, 2024

除了 dtype == VarType.FP32 这样的,别的地方使用 VarType 需要修改嘛

这个 PR 合入后,会统一再检查下~

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其余看起来没有问题~

@paddle-bot paddle-bot bot added the contributor External developers label Feb 2, 2024
@SigureMo SigureMo added the HappyOpenSource 快乐开源活动issue与PR label Feb 2, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo SigureMo merged commit 5a15936 into PaddlePaddle:develop Feb 3, 2024
@SigureMo
Copy link
Member

SigureMo commented Feb 3, 2024

除了 dtype == VarType.FP32 这样的,别的地方使用 VarType 需要修改嘛

任务已上新~

VarType 残留还很多,之后我们会继续讨论看看哪些可以继续发放出来

@ooooo-create ooooo-create deleted the cleanup_A1 branch February 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants