Skip to content

[PIR][DynamicShape] Add InferSymbolicShapeInterface for prod #61342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lanxianghit merged 2 commits into from
Jan 31, 2024
Merged

[PIR][DynamicShape] Add InferSymbolicShapeInterface for prod #61342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c71807f
Add InferSymbolicShapeInterface for prod
lanxianghit Jan 30, 2024
3b1886a
fix typo
lanxianghit Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,30 @@ bool SumOpInferSymbolicShape(pir::Operation *op,
return true;
}

bool ProdOpInferSymbolicShape(pir::Operation *op,
pir::ShapeConstraintIRAnalysis *shape_analysis) {
auto attributes = op->attributes();
Copy link
Contributor

@zyfncg zyfncg Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以使用 const auto&

Copy link
Contributor Author

@lanxianghit lanxianghit Jan 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，后续统一修改一下吧，免得这个pr再重新过ci了

bool keepdim = attributes["keep_dim"].dyn_cast<pir::BoolAttribute>().data();

bool reduce_all =
attributes["reduce_all"].dyn_cast<pir::BoolAttribute>().data();

auto axis_gen_op = op->operand_source(1).defining_op();
if (axis_gen_op->isa<paddle::dialect::FullIntArrayOp>()) {
std::vector<int64_t> axis = GetVectorAttr(
axis_gen_op->dyn_cast<paddle::dialect::FullIntArrayOp>(), "value");
return ReduceInferDim(op, shape_analysis, axis, keepdim, reduce_all);
} else {
// TODO(lanxianghit): deal with other source: pir::VectorType,
// paddle::dialect::DenseTensorType
PADDLE_THROW(
phi::errors::Unimplemented("ProdOpInferSymbolicShape: 'axis' only "
"support FullIntArrayOp's result now."));
}

return true;
}

bool ReshapeOpInferSymbolicShape(
pir::Operation *op, pir::ShapeConstraintIRAnalysis *shape_analysis) {
pir::Value operand_source_shape = op->operand_source(1);
Expand Down
4 changes: 4 additions & 0 deletions paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ bool ReluOpInferSymbolicShape(pir::Operation *op,
pir::ShapeConstraintIRAnalysis *shape_analysis);
bool Relu_OpInferSymbolicShape(pir::Operation *op,
pir::ShapeConstraintIRAnalysis *shape_analysis);

bool ProdOpInferSymbolicShape(pir::Operation *op,
pir::ShapeConstraintIRAnalysis *shape_analysis);

} // namespace paddle::dialect

namespace cinn::dialect {
Expand Down
1 change: 1 addition & 0 deletions paddle/fluid/pir/dialect/operator/ir/ops.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,7 @@
kernel :
func : prod
backward : prod_grad
interfaces : paddle::dialect::InferSymbolicShapeInterface

- op : push_sparse_v2
args : (Tensor[] ids, Tensor[] w, Tensor[] out_grad_in, int embeddingdim = 11, int tableid = 0, str accessorclass = "", str ctrlabelname = "", int paddingid = 0, bool scalesparsegrad = true, str[] inputnames = {}, bool is_distributed = true)
Expand Down