Skip to content

Conversation

@wanghuancoder
Copy link
Contributor

@wanghuancoder wanghuancoder commented Jan 29, 2024

PR types

New features

PR changes

Others

Description

Pcard-67164

完成batch_norm_act_fuse_pass的开发和测试。
batch_norm_act_fuse_pass等同于老静态图中的paddle/fluid/framework/ir/mkldnn/batch_norm_act_fuse_pass.cc里的batch_norm_act_fuse_pass。

完成conv3d_bias_fuse_pass的开发和测试。
conv2d_bias_fuse_pass等同于老静态图中的paddle/fluid/framework/ir/mkldnn/conv_bias_mkldnn_fuse_pass.cc里的conv3d_bias_mkldnn_fuse_pass。

namespace {
class BatchNormActFusePattern : public paddle::drr::DrrPatternBase {
public:
BatchNormActFusePattern(std::string bn_name, std::string fused_bn_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const&?

@@ -0,0 +1,9 @@
file(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
新建目录的话,之前的pr添加的这个单测需要删掉吧

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个我删掉了

Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 9c4f344 into PaddlePaddle:develop Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants