Skip to content

add check for using subprocess #61290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
risemeup1 merged 8 commits into from
Jan 30, 2024
Merged

add check for using subprocess #61290

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d08a5d
fix,test=document_fix
risemeup1 Jan 29, 2024
d839c21
fix,test=document_fix
risemeup1 Jan 29, 2024
50a517d
fix
risemeup1 Jan 29, 2024
217294b
fix,test=document_fix
risemeup1 Jan 29, 2024
eef26ef
fix,test=document_fix
risemeup1 Jan 29, 2024
eb75110
fix,test=document_fix
risemeup1 Jan 29, 2024
e953a77
document_fix
risemeup1 Jan 29, 2024
8e03839
fix,test=document_fix
risemeup1 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/check_file_diff_approvals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,12 @@ if echo "$DIFF_OUTPUT" | grep -q 'diff --git a/paddle/phi/kernels/.*\.cc b/paddl
fi
fi

IF_USE_SUBPROCESS=`git diff -U5 upstream/$BRANCH -- '*.py' | grep -B5 --no-group-separator "subprocess" || true`
if [[ ${IF_USE_SUBPROCESS} ]]; then
echo_line="You must have one RD wanghuancoder approval for using subprocess, which may cause security problem.\n"
check_approval 1 wanghuancoder
fi

HAS_DEFINE_FLAG=`git diff -U0 upstream/$BRANCH |grep -o -m 1 "DEFINE_int32" |grep -o -m 1 "DEFINE_bool" | grep -o -m 1 "DEFINE_string" || true`
if [ ${HAS_DEFINE_FLAG} ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD lanxianghit approval for the usage (either add or delete) of DEFINE_int32/DEFINE_bool/DEFINE_string flag.\n"
Expand Down