Update global_value_getter_setter.cc #61273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
previously approved these changes
Jan 30, 2024
sneaxiy
reviewed
Feb 2, 2024
| REGISTER_PUBLIC_GLOBAL_VAR(FLAGS_rpc_get_thread_num); | ||
| REGISTER_PUBLIC_GLOBAL_VAR(FLAGS_rpc_prefetch_thread_num); | ||
| #endif | ||
| // #ifdef PADDLE_WITH_DISTRIBUTE |
Collaborator
There was a problem hiding this comment.
Please remove useless codes instead of commenting them.
luotao1
reviewed
Feb 2, 2024
| // #ifdef PADDLE_WITH_DISTRIBUTE | ||
| // REGISTER_PUBLIC_GLOBAL_VAR(FLAGS_rpc_get_thread_num); | ||
| // REGISTER_PUBLIC_GLOBAL_VAR(FLAGS_rpc_prefetch_thread_num); | ||
| // #endif |
Contributor
sneaxiy
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Fix PADDLE_WITH_DITRIBUTE PADDLE_WITH_DISTRIBUTE
注释没有使用代码，如果开启CI错误