[PIR] pir onednn support conv2d_transpose #61165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pir_onednn_conv2d_transpose
…e/Paddle into pir_onednn_conv2d_transpose
… pir_onednn_conv2d_transpose
yuanlehome
reviewed
Mar 6, 2024
| #include "paddle/pir/include/core/operation.h" | ||
| #include "paddle/pir/include/core/value.h" | ||
| #ifdef PADDLE_WITH_DNNL | ||
| #include "build/paddle/fluid/pir/dialect/operator/ir/onednn_op.h" |
Contributor
Author
There was a problem hiding this comment.
好的好的，感谢感谢。现在每次从icoding里复制文件路径都带build，汗
zyfncg
reviewed
Mar 6, 2024
Comment on lines
+77
to
+86
| std::vector<int> strides; | ||
| for (size_t i = 0; | ||
| i < attrs.at("strides").dyn_cast<pir::ArrayAttribute>().size(); | ||
| i++) { | ||
| strides.push_back(attrs.at("strides") | ||
| .dyn_cast<pir::ArrayAttribute>() | ||
| .at(i) | ||
| .dyn_cast<pir::Int32Attribute>() | ||
| .data()); | ||
| } |
Contributor
There was a problem hiding this comment.
ArrayAttribute转普通vector有没有提供一些工具函数，用公共函数能省不少行
Contributor
Author
There was a problem hiding this comment.
这个是从生成的代码里copy过来的。这样的工具函数暂时没有。先写成这样吧。
Contributor
Author
There was a problem hiding this comment.
这一块我觉得可以放在pattern实现里的
pattern是负责匹配的。匹配阶段好像只有“描述”信息，没有实例化Operation。pattern能实现承载这个逻辑吗？
zyfncg
approved these changes
Mar 7, 2024
yuanlehome
approved these changes
Mar 7, 2024
Aurelius84
approved these changes
Mar 7, 2024
Galaxy1458
approved these changes
Mar 7, 2024
winter-wang
approved these changes
Mar 7, 2024
winter-wang
reviewed
Mar 7, 2024
| .data()); | ||
| } | ||
|
|
||
| IR_ENFORCE(attrs.find("padding_algorithm") != attrs.end(), |
Contributor
There was a problem hiding this comment.
禁止使用IR_ENFORCE, 这儿需要改成PADDLE_ENFORCE_EQ。其它地方类似。具体参考https://github.com/PaddlePaddle/Paddle/wiki/PADDLE_ENFORCE-Rewriting-Specification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-67164
pir onednn 支持conv2d_transpose，conv2d_transpose_bias。
并支持conv2d_transpose_bias_fuse_pass。