[PIR] pir onednn add conv2d test, and support fused_conv2d #60974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
wanghuancoder
changed the title
zhangbo9674
reviewed
Jan 23, 2024
| auto legacy_attr_name = | ||
| op_normalizer.GetLegacyAttrName(fluid_op_name, attr_name); | ||
| if (legacy_attr_name != attr_name) { | ||
| extra_attr_[legacy_attr_name] = extra_attr_[attr_name]; |
Contributor
There was a problem hiding this comment.
extra_attr_ 和 ctx_attr_ 必须要使用 legacy_attr_name 么？后续就算子退场，这里是不是还要重新适配？
Contributor
Author
There was a problem hiding this comment.
OneDNN底层的Kernel通过Ctx使用的Attr情况如下：
- 他既使用extra的Attr，也通过ctx使用PHI kernel签名的Attr。
- 他既支持Operators渠道的调用，又支持PHI渠道的调用。因此底层取Attr时，使用的是Operators里Attr的命名规范（首字母大写）。因此我需要把legacy_attr_name给到Ctx。
zhangbo9674
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-67164
PIR-OneDNN添加全量conv2d,conv2d_grad的单测。支持fused_conv2d。
并解决一些遇到的机制上的问题。