Skip to content

Conversation

@jiahy0825
Copy link
Contributor

@jiahy0825 jiahy0825 commented Jan 17, 2024

PR types

Others

PR changes

Others

Description

pcard-76996

[DimExpr] Remove adt DimExpr

强约束分支中的 DimExpr,已经作为底层基础组件,复用到了动态形状链条上。然而,在 adt 目录下,还存在另一套 DimExpr 实现,不利于项目的整体维护。

本 PR 对 adt 目录中的 DimExpr 做了清理,从而和动态形状链条复用同一套 DimExpr 组件。

@paddle-bot
Copy link

paddle-bot bot commented Jan 17, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

risemeup1
risemeup1 previously approved these changes Jan 18, 2024
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiahy0825 jiahy0825 merged commit 3727ad1 into PaddlePaddle:develop Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants