[Dynamic shape] Add some more symbolic shape infer funcs #60899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zhangboSJTU
changed the title
zyfncg
reviewed
Jan 18, 2024
Comment on lines
+365
to
+368
| bool MultiplySrOpInferSymbolicShape( | ||
| pir::Operation *op, pir::ShapeConstraintIRAnalysis *shape_analysis) { | ||
| return InferSymbolicShapeElementWiseBinary(op, shape_analysis); | ||
| } |
Contributor
There was a problem hiding this comment.
SelectedRows的还需要支持吗？这类Tensor编译器应该也处理不了
Contributor
Author
There was a problem hiding this comment.
这个 PIR 相关代码解析 yaml 的时候、 CodeGen 的时候会自动生成、因此需要加上函数、其实现调用 DenseTensor 的即可
Contributor
There was a problem hiding this comment.
这个的维度信息和dense_tensor的可能还有差别，建议先直接报错吧
|
|
||
| bool FullOpInferSymbolicShape(pir::Operation *op, | ||
| pir::ShapeConstraintIRAnalysis *shape_analysis) { | ||
| return true; |
Contributor
There was a problem hiding this comment.
这里面可以加一些TODO和高级别的LOG，实现的时候也好找
Contributor
Author
There was a problem hiding this comment.
这个在PASS 循环里会有 LOG、相关的推导正在补全中、为了防止冲突 、我先把本地代码 push 上去
zyfncg
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Pcard-67164
Add some more symbolic shape infer funcs