[Dy2St] Cleanup StaticAnalysis and create_fill_constant_node
#60870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
DrRyanHuang
approved these changes
Jan 17, 2024
Contributor
DrRyanHuang
left a comment
DrRyanHuang
left a comment
There was a problem hiding this comment.
https://github.com/cattidea/Paddle/blob/2432e49ce12209d979abebb99299efdcd262bf27/test/dygraph_to_static/test_tensor_hook.py#L133-L168
这段注释掉的代码，是否需要添加一个TODO:
TODO: 目前动转静暂不支持动态图下对 Tensor 调用 register_hook
Member
Author
这个 TODO 你是咋知道的？而且看这个 case 好像也不是在动态图调用？ |
Contributor
Member
Author
这是在那之前写的吧，就是因为没支持所以当时发了个任务支持的 |
gouzil
approved these changes
Jan 17, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
清理 AST 动转静下
StaticAnalysis和create_fill_constant_node代码和对应的单测PCard-66972