[PIR+CINN]refactor cinn pir compiler temp buffer #60562
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
|
Sorry to inform you that 55e869b's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
… factor_pir_temp_buffers
phlrain
changed the title
|
|
||
| using cinn::hlir::op::ExternalApiRegistry; | ||
|
|
||
| // Collect the temporary tensors from a computational graph. |
There was a problem hiding this comment.
这个如果没有额外依赖的话，建议放到cinn/lang/lower.cc中，与lang::GetTempBuffers 其他函数放到一起。
There was a problem hiding this comment.
看了下lang的namespace下已经有一个同名函数了，但可以在function name区分下？
| } | ||
|
|
||
| std::vector<ir::Buffer> temp_buffers; | ||
| for (auto& i : name_to_buffer) temp_buffers.push_back(i.second); |
There was a problem hiding this comment.
虽然for的body只有一行，也建议用{}包裹一下
| !tensor_arg_names.count(x->as_tensor()->name)) || | ||
| utils::Endswith(x->as_tensor()->buffer->name, "temp_buffer")); | ||
| }); | ||
| for (auto& e : all_temp_tensors) { |
There was a problem hiding this comment.
这里相对于旧的逻辑少了CollectIRNodesWithoutTensor，这个是符合预期的吗？
Aurelius84
left a comment
Aurelius84
left a comment
There was a problem hiding this comment.
后续我们得考虑如何清理和统一这里的逻辑，看起来已经有比较大的维护成本了
2 participants
PR types
Function optimization
PR changes
Others
Description
Pcard-67164
优化 pir compiler内部的buffer 构造逻辑，移除无用的stage的参数；该重构只是一个准备性的改造，目的是为了后续codegen阶段的逻辑优化，当前是由多处构造temp buffer的逻辑，这些逻辑相同，但是实现不统一