[PIR+CINN]add merge reshape with broadcast pass #60533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry to inform you that 05ba879's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
phlrain
changed the title
… add_merge_reshape_with_broadcast_pass
zyfncg
previously approved these changes
Jan 15, 2024
Aurelius84
reviewed
Jan 15, 2024
| namespace ir { | ||
|
|
||
| bool CanMerge(pir::Operation* op) { | ||
| auto in_dims = op->operand_source(0) |
Contributor
There was a problem hiding this comment.
Suggested change
| auto in_dims = op->operand_source(0) | |
| auto& in_dims = op->operand_source(0) |
| .type() | ||
| .dyn_cast<paddle::dialect::DenseTensorType>() | ||
| .dims(); | ||
| auto out_dims = |
Contributor
There was a problem hiding this comment.
Suggested change
| auto out_dims = | |
| auto &out_dims = |
|
|
||
| std::vector<int64_t> GetBroadcastAxis(pir::Operation* reshape_op, | ||
| pir::Operation* broadcast_op) { | ||
| auto in_dims = |
Contributor
There was a problem hiding this comment.
Suggested change
| auto in_dims = | |
| auto &in_dims = |
Collaborator
Author
There was a problem hiding this comment.
这个有phi::vectorize 操作，不能用 &
| .type() | ||
| .dyn_cast<paddle::dialect::DenseTensorType>() | ||
| .dims()); | ||
| auto out_dims = |
Contributor
There was a problem hiding this comment.
Suggested change
| auto out_dims = | |
| auto& out_dims = |
Collaborator
Author
There was a problem hiding this comment.
这个有phi::vectorize 操作，不能用 &
|
|
||
| std::vector<int64_t> new_broadcast_axes(in_dims.size(), 0); | ||
| // two step alignment | ||
| // 1 step |
Contributor
There was a problem hiding this comment.
注释也有一定的规范，这里比较精简，可以删除或者补充代码注释
| op_broadcast_axes[forward_out_index]; | ||
| } | ||
|
|
||
| for (auto dim : new_broadcast_axes) { |
| pir::RewritePatternSet MergeReshapeWithBroadcastPass::InitializePatterns( | ||
| pir::IrContext* context) { | ||
| pir::RewritePatternSet ps(context); | ||
| // elementwise ops |
… add_merge_reshape_with_broadcast_pass
… add_merge_reshape_with_broadcast_pass
… add_merge_reshape_with_broadcast_pass
zyfncg
approved these changes
Jan 17, 2024
Aurelius84
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
Others
Description
Pcard-67164
由于cinn里面的broadcast 自带了reshape功能，因此把连续的reshape和broadcast 进行合并