Skip to content

Fix grpc compile warning #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typhoonzero merged 3 commits into from
Dec 1, 2017
Merged

Fix grpc compile warning #6050

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ae9bc
fix grpc compile warn
Yancey0623 Nov 29, 2017
13b9d52
update
Yancey0623 Dec 1, 2017
4e4ca37
-Wnon-virtual-dtor -> -Wno-non-virtual-dtor
Yancey0623 Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions paddle/operators/detail/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
grpc_library(sendrecvop_grpc SRCS recv_impl.cc send_impl.cc PROTO send_recv.proto DEPS lod_tensor selected_rows)
set_source_files_properties(
Copy link
Contributor

@typhoonzero typhoonzero Nov 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these lines in the function grpc_library? This is only needed for the grpc dependencies.

Copy link
Contributor Author

@Yancey0623 Yancey0623 Dec 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete these lines and add flag -Wno-non-virtual-dtor in send/recv prpoerties.

recv_impl.cc send_impl.cc send_recv.grpc.pb.cc
PROPERTIES
COMPILE_FLAGS "-Wno-non-virtual-dtor -Wno-error=non-virtual-dtor -Wno-error=delete-non-virtual-dtor")