Skip to content

[CodeStyle] Add CI for checking enable_to_static in related test files #60037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SigureMo merged 14 commits into from
Dec 15, 2023
Merged

[CodeStyle] Add CI for checking enable_to_static in related test files #60037

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ad6de09
add codestyle check
DrRyanHuang Dec 15, 2023
fc79987
change checker
DrRyanHuang Dec 15, 2023
c82f47d
add test dir constrain
DrRyanHuang Dec 15, 2023
c4c7c8e
update echo line checker
DrRyanHuang Dec 15, 2023
33fcbf3
fix codestyle
DrRyanHuang Dec 15, 2023
901940e
test enable_to_static in test dir
DrRyanHuang Dec 15, 2023
0a32d88
fix TEST_FILE_ADDED_LINES
DrRyanHuang Dec 15, 2023
dc84284
echo info
DrRyanHuang Dec 15, 2023
7c064c2
mv test pos
DrRyanHuang Dec 15, 2023
7e01657
add -- before path
DrRyanHuang Dec 15, 2023
c34e956
test not in test dir
DrRyanHuang Dec 15, 2023
434e895
test unitest in test dir
DrRyanHuang Dec 15, 2023
7c1cdee
rm useless code
DrRyanHuang Dec 15, 2023
07ad66a
del space line
DrRyanHuang Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/paddle/tensor/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6223,6 +6223,7 @@ def sgn(x, name=None):
(-1+0j) ]])

"""

if x.dtype not in [
paddle.float16,
paddle.float32,
Expand Down
3 changes: 3 additions & 0 deletions test/legacy_test/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ def test_error(self):
self.assertRaises(AssertionError, paddle.static.data, 'a', [2, 25])
paddle.enable_static()

paddle.jit.enable_to_static(True)
paddle.jit.enable_to_static(False)


if __name__ == "__main__":
Copy link
Contributor Author

@DrRyanHuang DrRyanHuang Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅验证单测中有 enable_to_static 会报错

2023-12-15 17:52:52 ****************-----------------
2023-12-15 17:52:52 +++ b/test/legacy_test/test_data.py + paddle.jit.enable_to_static(True) + paddle.jit.enable_to_static(False) +
2023-12-15 17:52:52 + paddle.jit.enable_to_static(True) + paddle.jit.enable_to_static(False)
2023-12-15 17:52:52 ****************-----------------

2023-12-15 17:53:25 ****************
2023-12-15 17:53:25 0. You must have one RD (SigureMo, Aurelius84 or 2742195759) approval for using 'paddle.jit.enable_to_static', we recommend using 'enable_to_static_guard' in the related test files.
2023-12-15 17:53:25 There are 1 approved errors.
2023-12-15 17:53:25 ****************

image
image

unittest.main()
11 changes: 11 additions & 0 deletions tools/check_file_diff_approvals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,17 @@ if [ "${DEPRECATED_FLAKE8}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
check_approval 1 SigureMo gouzil
fi

TEST_FILE_ADDED_LINES=$(git diff -U0 upstream/$BRANCH -- test |grep "^+")
echo "****************-----------------"
echo $TEST_FILE_ADDED_LINES
ENABLE_TO_STATIC_CHECK=`echo "$TEST_FILE_ADDED_LINES" | grep "enable_to_static(" || true`
echo $ENABLE_TO_STATIC_CHECK
echo "****************-----------------"
if [ "${ENABLE_TO_STATIC_CHECK}" != "" ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (SigureMo, Aurelius84 or 2742195759) approval for using 'paddle.jit.enable_to_static', we recommend using 'enable_to_static_guard' in the related test files.\n"
check_approval 1 SigureMo Aurelius84 2742195759
fi

HAS_MODIFIED_PHI_FILES=`git diff --name-only upstream/$BRANCH | grep "paddle/phi/" || true`
PHI_INCLUDE_FLUID_FILES=""
for CHANGE_FILE in ${HAS_MODIFIED_PHI_FILES}; do
Expand Down