Skip to content

add arg check for cummax #59979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghuancoder merged 2 commits into from
Dec 14, 2023
Merged

add arg check for cummax #59979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6627d6e
add arg check for cummax
wanghuancoder Dec 13, 2023
deb7e27
refine
wanghuancoder Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions paddle/phi/infermeta/unary.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,21 +590,6 @@ void CumWithIndicesInferMeta(const MetaTensor& x,
phi::errors::InvalidArgument(
"dtype of indices must be DataType::INT32 or DataType::INT64"));

if (dtype == DataType::INT32) {
int _axis = 0;
if (axis < 0) {
_axis = axis + x_dims.size();
} else {
_axis = axis;
}
PADDLE_ENFORCE_LT(
common::vectorize(x_dims)[_axis],
INT32_MAX,
phi::errors::OutOfRange(
"cummax with axis %ld may be overflow, set dtype int64 to continue",
axis));
}

if (x_dims.size() > 0) {
PADDLE_ENFORCE_GE(
axis,
Expand Down Expand Up @@ -633,6 +618,21 @@ void CumWithIndicesInferMeta(const MetaTensor& x,
axis));
}

if (dtype == DataType::INT32) {
int _axis = 0;
if (axis < 0) {
_axis = axis + x_dims.size();
} else {
_axis = axis;
}
PADDLE_ENFORCE_LT(
common::vectorize(x_dims)[_axis],
INT32_MAX,
phi::errors::OutOfRange(
"cummax with axis %ld may be overflow, set dtype int64 to continue",
axis));
}

out->set_dims(x_dims);
out->set_dtype(x.dtype());
out->share_lod(x);
Expand Down