Skip to content

[SOT][3.11] Remove trailing PRECALL to avoid wrong specialization #59860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feifei-111 merged 4 commits into from
Dec 14, 2023
Merged

[SOT][3.11] Remove trailing PRECALL to avoid wrong specialization #59860

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3fb28e
[SOT][3.11] Remove trailing PRECALL to avoid wrong specializition
SigureMo Dec 8, 2023
e1892b9
Merge branch 'develop' into sot/remove-trailing-precall
SigureMo Dec 12, 2023
3c668bf
add check pass and cleanup tricks
SigureMo Dec 12, 2023
87675e8
rename ut
SigureMo Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions python/paddle/jit/sot/opcode_translator/executor/function_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,13 @@ def load(self, var):
restore_instr_names = [
instr.opname for instr in restore_instrs[:instr_idx]
]
# NOTE(SigureMo): Trailing KW_NAMES + PRECALL is no need to restore in Python 3.11+
if restore_instr_names[-2:] == ["KW_NAMES", "PRECALL"]:
restore_instrs = restore_instrs[:-2]
# NOTE(SigureMo): Trailing KW_NAMES or PRECALL is no need to restore in Python 3.11+
if restore_instr_names[-1:] == ["PRECALL"]:
restore_instrs = restore_instrs[:-1]
restore_instr_names = restore_instr_names[:-1]
if restore_instr_names[-1:] == ["KW_NAMES"]:
restore_instrs = restore_instrs[:-1]
restore_instr_names = restore_instr_names[:-1]

self.pycode_gen.extend_instrs(restore_instrs)
nop = self.pycode_gen._add_instr("NOP")
Expand Down