【pir】optimize backward code #59844
Merged
【pir】optimize backward code #59844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Aurelius84
approved these changes
Dec 11, 2023
| record relationship of forward op/value and backward op/value | ||
| one state must be bining with a program | ||
| one state must be bining with a block, if block has parent block, | ||
| state will include parent block info. |
Contributor
There was a problem hiding this comment.
函数注释可以考虑采用如下规范：
- 首句概要概括函数或类的角色或作用，且首字母大写。
- 可以是动名词开头，如Recording xxx ；或名词+定语，如 A stateful container class that recording xxx
- 文案遵循语法。
Contributor
Author
There was a problem hiding this comment.
感谢，后续提PR修改
| """ | ||
| record relationship of forward op/value and backward op/value | ||
| one state must be bining with a program | ||
| one state must be bining with a block, if block has parent block, |
Contributor
There was a problem hiding this comment.
Suggested change
| one state must be bining with a block, if block has parent block, | |
| One state must be bound with a block. If the block has parent block, |
| record relationship of forward op/value and backward op/value | ||
| one state must be bining with a program | ||
| one state must be bining with a block, if block has parent block, | ||
| state will include parent block info. |
Contributor
There was a problem hiding this comment.
Suggested change
| state will include parent block info. | |
| state will include parent block information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
others
PR changes
others
Description
pcard-67164
优化ir_backward， 将控制流数据结构绑定在state结构中
提取公共函数grad_semantics_for_op