[PIR] delete use mkldnn for bf16 #59797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
1 similar comment
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
… del_python_use_mkldnn3
wanghuancoder
changed the title
wanghuancoder
changed the title
Aurelius84
approved these changes
Dec 13, 2023
zhangbo9674
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
MKLDNN改造
清理python端对use_mkldnn的标记，原则上，use_mkldnn是由pass来决定的，Python端不应该处理use_mkldnn。
本PR删除BF16情况下，Python端对Program的特殊处理。因为新IR将无法兼容这种使用方法。
之所以在BF16下强行让能走MKLDNN的kernel尽量走MKLDNN，是因为CPU kernel有很多不支持BF16。因此本PR改成如果CPU kernel不支持BF16的情况下，而MKLDNN kernel支持，则改用MKLDNN kernel。
但在修改后发生一些CI case报错发现是：
Pcard-67164