[PIR] add UNMATCHED_TYPE #59784
Merged
[PIR] add UNMATCHED_TYPE #59784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
YuanRisheng
reviewed
Dec 11, 2023
0x45f
reviewed
Dec 12, 2023
Contributor
|
刚才和相关同学讨论了一下，error名字还是叫phi::errors::InvalidType吧，辛苦修改一下相关的代码，一并解决一下冲突~ |
0x45f
reviewed
Dec 13, 2023
Co-authored-by: WangZhen <[email protected]>
Co-authored-by: WangZhen <[email protected]>
Co-authored-by: WangZhen <[email protected]>
Co-authored-by: WangZhen <[email protected]>
0x45f
approved these changes
Dec 15, 2023
YuanRisheng
approved these changes
Dec 15, 2023
Aurelius84
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
[PIR] add UNMATCHED_TYPE
在 C++ 端添加 UNMATCHED_TYPE 错误类型，以便区分 value 错误和 type 错误