[Prim][PIR] Sink decomp graph #59448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
❌ The PR is not created using PR's template. You can refer to this Demo. |
cyber-pioneer
changed the title
cxxly
previously approved these changes
Dec 14, 2023
Contributor
cxxly
left a comment
cxxly
left a comment
There was a problem hiding this comment.
LGTM with TODO:
- 下沉机制成熟之后，sink_decomp -> decomp，移除旧的代码
Contributor
Author
ok |
Charles-hit
reviewed
Dec 14, 2023
| for (auto item : op->operands()) { | ||
| auto value = item.source(); | ||
| // check if initialized in case of optional input. | ||
| if (value.impl() && value.type().storage()) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (value.impl() && value.type().storage()) { | |
| if (IsEmptyValue(value)) { |
Charles-hit
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
Pcard-66975
Sink decomp mechanism into cpp. In future, decomp mechanism will run in cpp by default.