Skip to content

【PIR API adaptor No.36】check_numerics #58879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0x45f merged 10 commits into from
Dec 1, 2023
Merged

【PIR API adaptor No.36】check_numerics #58879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9e5129f
Update debugging.py
Liyulingyue Nov 9, 2023
a2cc730
Update test_nan_inf.py
Liyulingyue Nov 9, 2023
db5335b
Apply suggestions from code review
Liyulingyue Nov 9, 2023
d113917
Apply suggestions from code review
Liyulingyue Nov 9, 2023
5608dce
Update test_nan_inf.py
Liyulingyue Nov 15, 2023
5249aa0
Update test_nan_inf.py
Liyulingyue Nov 16, 2023
ad7559a
Merge branch 'PaddlePaddle:develop' into 36
Liyulingyue Nov 21, 2023
08fc435
Update test_nan_inf.py
Liyulingyue Nov 21, 2023
23602a4
Merge branch 'PaddlePaddle:develop' into 36
Liyulingyue Nov 29, 2023
1c1a199
Apply suggestions from code review
Liyulingyue Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/paddle/amp/debugging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
from paddle.base import core
from paddle.base.framework import dygraph_only

from ..framework import LayerHelper, in_dynamic_mode
from ..framework import LayerHelper, in_dynamic_or_pir_mode

__all__ = [
"DebugMode",
Expand Down Expand Up @@ -372,7 +372,7 @@ def check_numerics(
stack_height_limit = -1
output_dir = ""

if in_dynamic_mode():
if in_dynamic_or_pir_mode():
return _C_ops.check_numerics(
tensor,
op_type,
Expand Down
27 changes: 18 additions & 9 deletions test/legacy_test/test_nan_inf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@
import numpy as np

import paddle
from paddle.framework import in_pir_mode
from paddle.pir_utils import test_with_pir_api


class TestNanInfBase(unittest.TestCase):
Expand Down Expand Up @@ -299,6 +301,7 @@ def test_eager(self):
debug_mode=paddle.amp.debugging.DebugMode.CHECK_ALL,
)

@test_with_pir_api

This comment was marked as resolved.

Sign in to view

def test_static(self):
paddle.enable_static()
shape = [8, 8]
Expand All @@ -310,16 +313,22 @@ def test_static(self):
x = paddle.static.data(name='x', shape=[8, 8], dtype="float32")
y = paddle.static.data(name='y', shape=[8, 8], dtype="float32")
out = paddle.add(x, y)
paddle.amp.debugging.check_numerics(
tensor=out,
op_type="elementwise_add",
var_name=out.name,
debug_mode=paddle.amp.debugging.DebugMode.CHECK_ALL,
)
if in_pir_mode():
paddle.amp.debugging.check_numerics(
tensor=out,
op_type="elementwise_add",
var_name=out.id,
debug_mode=paddle.amp.debugging.DebugMode.CHECK_ALL,
)
else:
paddle.amp.debugging.check_numerics(
tensor=out,
op_type="elementwise_add",
var_name=out.name,
debug_mode=paddle.amp.debugging.DebugMode.CHECK_ALL,
)
exe = paddle.static.Executor(paddle.CPUPlace())
exe.run(
main_program, feed={"x": x_np, "y": y_np}, fetch_list=[out.name]
)
exe.run(main_program, feed={"x": x_np, "y": y_np}, fetch_list=[out])
paddle.disable_static()


Expand Down