Feature/enhance evaluator #5824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhwinter
previously approved these changes
Nov 23, 2017
Contributor
dzhwinter
left a comment
dzhwinter
left a comment
There was a problem hiding this comment.
Looks much better than the previous implementation. If we go this way, there are two concerns.
- If a user wants to custom an evaluator, he needs to modify the layers and the evaluator.
- layers will be a core library in Python, it will be explosion increased after we complete it.
We can merge this PR and make that decision offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accuracymethod, since users can directly new aAccuarcyclassFix #5825