Simpily demo, add paddle.default_main_program() and paddle.default_startup_program()#5615
Merged
helinwang merged 6 commits intoPaddlePaddle:developfrom Nov 15, 2017
Merged
Simpily demo, add paddle.default_main_program() and paddle.default_startup_program()#5615helinwang merged 6 commits intoPaddlePaddle:developfrom
helinwang merged 6 commits intoPaddlePaddle:developfrom
Conversation
helinwang
force-pushed
the
demo
branch
2 times, most recently
from
5f1c9eb to
349c078
Compare
jacquesqiao
reviewed
Nov 14, 2017
python/paddle/v2/__init__.py
Outdated
Member
There was a problem hiding this comment.
v2这个应该不用修改，目前重构的代码都在 framework下
Contributor
Author
There was a problem hiding this comment.
嗯，确认下是这样用吗：paddle.framework.default_startup_program()？
Contributor
There was a problem hiding this comment.
Will we publish our new API under framework? It is a little strange that our refactorization API all put into framework directory.
dzhwinter
reviewed
Nov 14, 2017
Contributor
There was a problem hiding this comment.
Why we need to wrap the main program into a global function....
dzhwinter
previously approved these changes
Nov 14, 2017
Contributor
dzhwinter
left a comment
dzhwinter
left a comment
There was a problem hiding this comment.
The only one concern is the default_startup_program location. Other parts look good to me.
…artup_program - Removed all main_program and startup_program in the demo. - Using paddle.default_main_program() hides the implementation detail (e.g., using g_main_program) from the user, we can change the implementation in the future much easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5614 #5305 #5301