Correct the install command, static library name and typo in nccl.cmake.#5048
Merged
Xreki merged 2 commits intoPaddlePaddle:developfrom Oct 25, 2017
Merged
Correct the install command, static library name and typo in nccl.cmake.#5048Xreki merged 2 commits intoPaddlePaddle:developfrom
Xreki merged 2 commits intoPaddlePaddle:developfrom
Conversation
luotao1
approved these changes
Oct 25, 2017
| else() | ||
| # otherwise, we build nccl and link it. | ||
| set(NCCL_INSTALL_DIR ${THIRD_PARTY_PATH}/install/nccl) | ||
| # Note: cuda 8.0 is needed to make nccl |
Contributor
Author
There was a problem hiding this comment.
因为nccl的Makefile里面设定了NVCC_GENCODE变量，-gencode=arch=compute_60,code=sm_60以上在cuda 8.0才支持。
https://github.com/NVIDIA/nccl/blob/master/Makefile#L20-L25
不过，NVCC_GENCODE这个变量应该也可以在make传进去，比如：
set(NVCC_GENCODE -gencode=arch=compute_35,code=sm_35
-gencode=arch=compute_50,code=sm_50
-gencode=arch=compute_52,code=sm_52)
set(NCCL_BUILD_COMMAND "make NVCC_GENCODE=${NVCC_GENCODE}")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I try to build nccl manually, using
make CUDA_HOME=$CUDA_ROOT, and I get the following outputs:The static library's name is
libnccl_static.a.I try
make installto install the library, and get errors:We need to specify the install directory as
make install PREFIX=install: