Add a warning to the docstring of Parameters.to_tar()#5033
Merged
pengli09 merged 2 commits intoPaddlePaddle:developfrom Oct 24, 2017
Merged
Add a warning to the docstring of Parameters.to_tar()#5033pengli09 merged 2 commits intoPaddlePaddle:developfrom
pengli09 merged 2 commits intoPaddlePaddle:developfrom
Conversation
lcy-seso
reviewed
Oct 24, 2017
python/paddle/v2/parameters.py
Outdated
| Save parameters to a tar file. | ||
|
|
||
| WARNING: Do not use this function to save parameters directly unless you | ||
| know exactly what you are doing. `paddle.v2.trainer.SGD.save_parameter_to_tar(f)` |
Contributor
There was a problem hiding this comment.
“unless you know exactly what you are doing. ” 这个英文注释不太好。为什么不直接解释有什么风险呢？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.