Skip to content

Comments

Adding python wrapper for adam operator#5021

Merged
abhinavarora merged 3 commits intoPaddlePaddle:developfrom
abhinavarora:adam_python
Oct 24, 2017
Merged

Adding python wrapper for adam operator#5021
abhinavarora merged 3 commits intoPaddlePaddle:developfrom
abhinavarora:adam_python

Conversation

@abhinavarora
Copy link
Contributor

No description provided.

@abhinavarora abhinavarora self-assigned this Oct 23, 2017
self.assertEqual(len(params_grads), 1)
self.assertEqual(len(adam_optimizer.get_accumulators()), 0)
opts = adam_optimizer.create_optimization_pass(params_grads, mul_out)
self.assertEqual(len(opts), 3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the length of opts equal to 3 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the opts will include 3 ops:

  1. Adam op for the parameter
  2. increment op for beta1 power
  3. increment op for beta2 power

Copy link
Contributor

@kexinzhao kexinzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abhinavarora abhinavarora merged commit d78d119 into PaddlePaddle:develop Oct 24, 2017
@abhinavarora abhinavarora deleted the adam_python branch October 24, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants