Fix default GetExpectedKernelType for ops supported tensor attrs #49414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
added 3 commits
December 28, 2022 12:11
Aurelius84
reviewed
Dec 29, 2022
paddle/fluid/framework/operator.cc
Outdated
| auto tmp_list = ctx.InNameList(); | ||
| std::vector<std::string> in_name_list; | ||
| std::transform(tmp_list.begin(), | ||
| tmp_list.end(), |
paddle/fluid/framework/operator.cc
Outdated
| if (Info().HasOpProtoAndChecker()) { | ||
| for (auto& attr : Info().Proto().attrs()) { | ||
| auto it = | ||
| std::find(in_name_list.begin(), in_name_list.end(), attr.name()); |
Contributor
There was a problem hiding this comment.
这里使用std::find_if，第三个参数用lambda函数即可，会更简洁一些。用法参考：https://en.cppreference.com/w/cpp/algorithm/find
Aurelius84
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
修改默认的GetExpectedKernelType逻辑。默认GetExpectedKernelType的逻辑是根据inputs最后一个var的type选择kernel类型，但是支持可变attrs后对于tensor类型的attr会被加入到inputs，导致会被错误的通过attr选择kernel类型，本PR对这个错误进行了修复