Skip to content

Conversation

@Charles-hit
Copy link
Contributor

@Charles-hit Charles-hit commented Sep 19, 2022

PR types

Others

PR changes

Others

Describe

本次PR主要cherry-pick以下两个pr:
1.基于yaml自动代码生成支持cast op 反向复用前向实现无限阶并且添加二三阶单测。
修复高阶单测框架bug,在测试时数据准备阶段应该设置output的stop_gradient为False,否则可能会导致单测框架报错(主要原因是因为静态图下stop_gradient传递性未对齐动态图)。 PR46173
2.基于Yaml自动代码生成,通过配置sign_grad yaml ,利用sign_grad去复用scale前向动态图api实现无线阶并且补充二三阶单测。 PR46002

@paddle-bot
Copy link

paddle-bot bot commented Sep 19, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comment

v.persistable = True
y = _as_list(y)

for u in y:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this in right way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the inconsistency of the stop_gradient behavior of dynamic graphs and static graphs,we should consider refactoring the dynamic graph unit test framework in the future.

Copy link
Contributor

@veyron95 veyron95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit bc92d5f into PaddlePaddle:release/2.4 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants