Skip to content

Conversation

@feifei-111
Copy link
Contributor

PR types

others

PR changes

others

Describe

  1. user should only use 'to_static' to function 'forward'
  2. call decorated functions in 'forward' is allowed
  3. decorator will be transformed into function call
  4. support decos with args
  5. fixed a bug in return_transformer
  • Fixed a bug in decorator transformer, it can not analyze decorator with params correctly
    error happens when the param is empty

…dle#45768)

* support deco

* fix deco ast type

* arg_str

* 1

* support callable deco

* code style

* codestyle

* test_error

* fix decos in another file

* recover conflict codes
…orator with params correctly (PaddlePaddle#46055)

* fix deco call

* add raise

* add test

* add warn, fix paddle api

* fix error type

* fix coverage
@paddle-bot
Copy link

paddle-bot bot commented Sep 19, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@feifei-111 feifei-111 closed this Sep 19, 2022
@feifei-111 feifei-111 reopened this Sep 19, 2022
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit d1ce974 into PaddlePaddle:release/2.4 Sep 19, 2022
@feifei-111 feifei-111 deleted the cherry_fix_deco branch December 15, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants