Fix error in unit test of ModifiedHuberLossOp #4407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangkuiyi
reviewed
Sep 27, 2017
| return (1. - val) * (1. - val) | ||
| else: | ||
| return 0 | ||
| return 0. |
|
|
||
| def test_check_grad(self): | ||
| self.check_grad(['X'], 'Out', max_relative_error=0.005) | ||
| self.check_grad(['X'], 'Out', max_relative_error=0.01) |
Collaborator
There was a problem hiding this comment.
Just a random question: could we have a systematic way to set the error tolerance?
Collaborator
There was a problem hiding this comment.
There are a lot of indifferentiable points for forwarding operators. Only writers of operators could know which point is indifferentiable.
So I think that should be managed manually by Op writers.
reyoung
approved these changes
Sep 27, 2017
luotao1
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix paddle.get_default_dtype Chinese and English return values are inconsistent * fix paddle.matmul 文档评估 #4407 把函数的输出改成正确的 * fix paddle.std文档评估 #4370 增加了一个unbiased=False的代码示例，没有增加numpy,怕引起误会。 * fix paddle.load文档测评 #4455 只把代码拆分了5段 * try * try * try * Update io.py * Update io.py * Update creation.py * Update creation.py * [Docs]add name description * [Docs]fix broadcasting issue Co-authored-by: Ligoml <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4406