Skip to content

Conversation

@betterpig
Copy link
Contributor

@betterpig betterpig commented Jun 6, 2022

PR types

Others

PR changes

Others

Describe

add cmakelint to lint cmake files
some points:

image

- yapf‘s hook config should change sha to rev, to avoid warning.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 6, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 3af98de into PaddlePaddle:develop Jun 6, 2022
@betterpig betterpig deleted the cmakelint branch June 8, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants