Skip to content

Pass LoD from input to output in the operators. #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2017
Merged

Pass LoD from input to output in the operators. #4284

merged 8 commits into from
Sep 22, 2017

Conversation

@qingqing01
Copy link
Contributor

@qingqing01 qingqing01 commented Sep 21, 2017 •
edited
Loading

Fix #4047
Fix #4151

  1. Pass LoD from input to output in the operators.

  2. 去掉InferShape中LoDTensor

  3. 没有传递LoD的Op

    • concat_op:
      • @Yancey1989 正在写的sequence_concat会处理LoD
    • gather_op, scatter_op, cond_op:
      • 可能会改变LoD，目前该Op没有处理变长序列，如果将来处理变长序列，需要处理LoD
    • mean_op:
      • 输出是一个标量，不用传递
    • split_op：
      • 有个SubSequenceOp，序列任务或许会用SubSequenceOp。目前没有传递，以后如果有需要再加。
    • sgd_op等optimizer
    • uniform_random_op, gaussian_random_op给Tensor填充值的Op
    • softmax_op
      • 会有sequence_softmax_op
    • rank loss, huber loss, trans_op, conv_2d_op

@qingqing01 qingqing01 force-pushed the lod_share branch 2 times, most recently from 29651b1 to 531f124 Compare September 21, 2017 07:30
@qingqing01 qingqing01 requested a review from QiJune September 21, 2017 07:36
wangkuiyi
wangkuiyi previously approved these changes Sep 21, 2017
View reviewed changes
@qingqing01 qingqing01 merged commit 6117af6 into PaddlePaddle:develop Sep 22, 2017
@qingqing01 qingqing01 deleted the lod_share branch November 14, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hedaoyuan hedaoyuan hedaoyuan approved these changes

@wangkuiyi wangkuiyi wangkuiyi left review comments

@Superjomn Superjomn Awaiting requested review from Superjomn

@reyoung reyoung Awaiting requested review from reyoung

@luotao1 luotao1 Awaiting requested review from luotao1

@emailweixu emailweixu Awaiting requested review from emailweixu

@QiJune QiJune Awaiting requested review from QiJune

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qingqing01 @wangkuiyi @hedaoyuan