Revise CMake scripts to support ninja on Linux #42283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zlsh80826
changed the title
zlsh80826
changed the title
zlsh80826
requested review from
Avin0323,
raindrops2sea,
wanghuancoder and
zhwesky2010
zlsh80826
changed the title
|
Sorry to inform you that 8723e9e's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
zlsh80826
force-pushed
the
zlsh80826-ninja-build
branch
from
8723e9e to
1c3ec6f
Compare
zlsh80826
force-pushed
the
zlsh80826-ninja-build
branch
from
2f94bb4 to
4ea407c
Compare
Contributor
|
hi, any update for this PR? seems it does not work for current |
Contributor
|
Since #44210 is merged, could we close this PR? @zlsh80826 |
Collaborator
Author
|
Since #44210 is merged, close this PR. |
|
很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
修改 CMake 腳本使其支持 Linux 上的 Ninja 編譯
$(nproc)的用法, 改為透過 CMake ProcessorCount 取得機器上核心數, 並用NPROC變數紀錄使用, 以避開 Ninja 不支持$(var)語法的問題gflags下ExternalProjectAdd中利用$(MAKE)顯式調用BUILD_COMMAND,INSTALL_COMMAND的用法。ExternalProjectAdd預設會用cmake --build .來編譯 external projectrocksdb的BYPRODUCTS, 說明可參考這裡add_custom_target對ps.pb.h,ps.pb.cc新增 target, 並且補齊afs_wrapper對於ps.pb.h的依賴, 因為 afs_wrapper.cc 會 includeps.pb.h