-
Notifications
You must be signed in to change notification settings - Fork 5.9k
fix RNN and IfElse syntax in Block design #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c7cd48c
fix block syntax
Superjomn 59f3f3c
add builder
Superjomn d52dffd
fix argument names
Superjomn c5bd0f3
uniform all Var to var
Superjomn 6a2bf6c
fix c demo
Superjomn 0b83e80
factor set_outputs
Superjomn 5c2ea17
update block
Superjomn bf7d99d
Merge branch 'develop' of github.com:PaddlePaddle/Paddle into fix_blo…
Superjomn a3e1fd5
delete as_ifelse_input interface from block design
Superjomn ead84fe
simplify set_outputs and output_num
Superjomn 8b5e497
make the c++ codes compatible with demo
Superjomn dae0007
fix compatible
Superjomn c0bac84
fix syntax
Superjomn f897535
update ie
Superjomn 2e844a1
update syntax
Superjomn 50aeec4
Merge branch 'develop' of github.com:PaddlePaddle/Paddle into fix_blo…
Superjomn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RNN needs to differentiate static input and sequence input. Static input is same for every step. Sequence input will have to pick the corresponding data for each step. I suggest that static input uses same syntax as if-else, while sequence input needs to explicitly indicate it as step input (e.g., using as_step_input())