Refine platform::Transform function and fix prelu_op testing. #4201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedaoyuan
approved these changes
Sep 19, 2017
jacquesqiao
reviewed
Sep 19, 2017
| }; | ||
|
|
||
| #ifdef __NVCC__ | ||
| template <> |
Contributor
Author
There was a problem hiding this comment.
@jacquesqiao 改了之后，带了模板参数，对于CPUPlace 、 GPUPlace编译出来是两个不同的符号。
原先那样，在.cu文件编译后，链接时，用的是第一次g++/gcc编译同出来的同名符号，就出现问题。
Contributor
|
Such as the comment in the pr 4209, this code is more efficient after compile. |
reyoung
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4202
Fix #4204
Thanks for @hedaoyuan's help.