Skip to content

Comments

Add EigenDDim type#4090

Closed
reyoung wants to merge 1 commit intoPaddlePaddle:developfrom
reyoung:feature/eigen_ddim
Closed

Add EigenDDim type#4090
reyoung wants to merge 1 commit intoPaddlePaddle:developfrom
reyoung:feature/eigen_ddim

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Sep 13, 2017

  • Make DDim can convert to EigenDDim without template arguments
  • Add VisitEigenDDim helper. User can visit EigenDim by template
    visitor.

* Make DDim can convert to EigenDDim without template arguments
* Add VisitEigenDDim helper. User can visit EigenDim by template
  visitor.
@QiJune QiJune requested a review from JiayiFeng September 14, 2017 04:20
@QiJune
Copy link
Member

QiJune commented Sep 14, 2017

Please refer to PadOp. We must implement a PadFunction with template parameter Rank.
In this pr, we have EigenDDim to avoid using rank in EigenDim. Do we also need EigenDTensor to avoid using rank in EigenTensor?

@paddle-bot-old paddle-bot-old bot closed this May 22, 2020
@paddle-bot-old
Copy link

Since you haven't replied for a long time, we have closed this issue/pr.
If the problem is not solved or there is a follow-up one, please reopen it at any time and we will continue to follow up.
由于您长期未回复,我们将关闭这个issue/pr。
若问题未解决或有后续问题,请随时重新打开,我们会继续跟进。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants