Skip to content

[phi] move elementwise_max, elementwise_min, elmentwise_mod into phi#40590

Merged
FlyingQianMM merged 1 commit intoPaddlePaddle:developfrom
FlyingQianMM:phi_max_min_mod
Mar 25, 2022
Merged

[phi] move elementwise_max, elementwise_min, elmentwise_mod into phi#40590
FlyingQianMM merged 1 commit intoPaddlePaddle:developfrom
FlyingQianMM:phi_max_min_mod

Conversation

@FlyingQianMM
Copy link
Copy Markdown
Contributor

@FlyingQianMM FlyingQianMM commented Mar 15, 2022

PR types

Function optimization

PR changes

OPs

Describe

[phi] move elementwise_max, elementwise_min, elementwise_mod into phi

@paddle-bot-old
Copy link
Copy Markdown

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 15, 2022

CLA assistant check
All committers have signed the CLA.

@FlyingQianMM FlyingQianMM changed the title [phi] move elementwise_max, elementwise_min into phi [phi] move elementwise_max, elementwise_min, elmentwise_mod into phi Mar 21, 2022
Copy link
Copy Markdown
Contributor

@zyfncg zyfncg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个有op-benchmark脚本吗?

@FlyingQianMM
Copy link
Copy Markdown
Contributor Author

FlyingQianMM commented Mar 24, 2022

这几个有op-benchmark脚本吗?

@zyfncg maximum和minimum的有,但是Modulo没有。这个pr合入后,我再加下op-benchmark的

@FlyingQianMM FlyingQianMM reopened this Mar 24, 2022
Copy link
Copy Markdown
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlyingQianMM FlyingQianMM merged commit cfadf61 into PaddlePaddle:develop Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants