simplify the python/paddle/v2/framework/tests/CMakeLists.txt#4044
Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom Sep 13, 2017
luotao1:pytest_cmake
Merged
simplify the python/paddle/v2/framework/tests/CMakeLists.txt#4044luotao1 merged 2 commits intoPaddlePaddle:developfrom luotao1:pytest_cmake
luotao1 merged 2 commits intoPaddlePaddle:developfrom
luotao1:pytest_cmake
Conversation
typhoonzero
reviewed
Sep 12, 2017
doc/howto/dev/new_op_cn.md
Outdated
| ``` | ||
| py_test(test_mul_op SRCS test_mul_op.py) | ||
| ``` | ||
| 无需修改 [`python/paddle/v2/framework/tests/CMakeLists.txt`](https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/framework/tests/CMakeLists.txt) 文件，新增的 `test_*.py` 单元测试会被自动加入工程。 |
Contributor
There was a problem hiding this comment.
感觉既然是"无需修改"，就可以不用再提及这个Cmake文件了。文档的前面应该也有类似的地方。
Contributor
Author
There was a problem hiding this comment.
Done. 文档前面类似的地方也做了修改。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4028
related #3807