Merged
Conversation
reyoung
force-pushed
the
feature/remove_enforce_demagle
branch
from
a57139e to
dad5421
Compare
It is buggy in some Linux because the unique_ptr will be free however the std::string trying to use that char*. Moreover, it is no need to demangle for error log by Paddle. Just use `c++filt` or other shell utilities to do this.
wangkuiyi
approved these changes
Sep 11, 2017
Collaborator
wangkuiyi
left a comment
wangkuiyi
left a comment
There was a problem hiding this comment.
Please remember to add "Fix XXX" in the first comment before merging it.
Also, I still don't quite understand the reason of the bug. Should be better to explain more in the issue.
Xreki
approved these changes
Sep 11, 2017
Member
|
测试了下， inline std::string demangle(std::string name) { return name; }依然报同样的错误，所以不是unique_ptr的问题，是别的地方的问题。 |
Contributor
|
Fix #3935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is buggy in some Linux because the unique_ptr will be free however
the std::string trying to use that char*.
Moreover, it is no need to demangle for error log by Paddle.
Just use
c++filtor other shell utilities to do this.Fix #3864
Fix #3967
Fix #3858
Fix #3865