Fixed some ssd bugs.#3991
Merged
qingqing01 merged 5 commits intoPaddlePaddle:developfrom Sep 11, 2017
Noplz:develop
Merged
Conversation
qingqing01
previously approved these changes
Sep 11, 2017
| resetOutput(numKept, 7); | ||
| } else { | ||
| MatrixPtr outV = getOutputValue(); | ||
| outV = NULL; |
Contributor
There was a problem hiding this comment.
Better to add comments in the Python API. It is useful for users to know the output can be null if there are no detection results.
qingqing01
approved these changes
Sep 11, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssd confidence threshold 需要是浮点数，在confidence threshold过大的时候，detection output层会没有输出, output resize时候会报错。我觉得应该判断这种情况并返回一个全-1的output。