Skip to content

Supported Complex2Real Conversion for Eager Dygraph#39878

Merged
jim19930609 merged 24 commits intoPaddlePaddle:developfrom
jim19930609:support_complex
Mar 18, 2022
Merged

Supported Complex2Real Conversion for Eager Dygraph#39878
jim19930609 merged 24 commits intoPaddlePaddle:developfrom
jim19930609:support_complex

Conversation

@jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Feb 24, 2022

PR types

New features

PR changes

Others

Describe

Supported Complex2Real Conversion for Eager Dygraph

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to test more tests in test_imperative_auto_prune.py

@paddle-bot-old
Copy link

Sorry to inform you that 489e146's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments


// Set Grad out rank as same as fwd input and set stop gradient to bwd
scale_node->SetGradOutMeta(p_autograd_in, /*slot id*/ 0);
scale_node->SetGradOutMeta(x, /*slot id*/ 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we should remove this in later PR

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim19930609 jim19930609 merged commit e3b2a03 into PaddlePaddle:develop Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants