Closed
Conversation
reyoung
reviewed
Sep 7, 2017
Collaborator
reyoung
left a comment
reyoung
left a comment
There was a problem hiding this comment.
Maybe it should be named colwise_mul?
reyoung
reviewed
Sep 7, 2017
| } | ||
| }; | ||
|
|
||
| class ScalingGradOp : public framework::OperatorWithKernel { |
Collaborator
There was a problem hiding this comment.
The gradient operator could be composed by two forward operator. See minus_op.
reyoung
reviewed
Sep 7, 2017
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() | ||
| if __name__ == '__main__': |
Collaborator
There was a problem hiding this comment.
Maybe __main__ should not be defined twice.
Contributor
@reyoung Discussed with @kuke and @gongweibao , we'd like to merge this op with elementwise mul op. elementwise mul op can handle:
like caffe2: https://caffe2.ai/docs/operators-catalogue.html#mul |
Contributor
Author
|
@reyoung @qingqing01 thanks for your comments. I will work with @gongweibao to unify these mul ops. |
Contributor
Author
|
Closed this PR for #3787 has a more complete implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3766