add offset implementation to lod tensor design#3934
Merged
Superjomn merged 3 commits intoPaddlePaddle:developfrom Sep 6, 2017
Merged
add offset implementation to lod tensor design#3934Superjomn merged 3 commits intoPaddlePaddle:developfrom
Superjomn merged 3 commits intoPaddlePaddle:developfrom
Conversation
Comment on Chunwei's work
wangkuiyi
approved these changes
Sep 6, 2017
luotao1
reviewed
Sep 7, 2017
| 0 9 10 | ||
| 0 3 5 9 10 12 | ||
| ||| || |||| | || ||| | ||
| ``` |
Contributor
There was a problem hiding this comment.
有一些英文语法错误，需要再refine一下。另外需要说一下，为什么选择整体的length或offset，然后offset比length好的原因吧。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3837